Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=909671

Remi Collet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #8 from Remi Collet <[email protected]> ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5257399

SHOULD:

[!]: The spec file handles locales properly.

    As both packages share the same locale files,
    no need to run find_lang twice

[!]: %check is present and all tests pass.

    Make check doesn't run anything
    %check Can be removed

COULD:

[!]: Latest version is packaged.

    At one time, I think it will be great to 
    build official version (0.4.0) instead of snaphosts.

Perhaps, Changelog and README files can be moved to -devel.


No blocker.

=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HcruWdLbF7&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to