Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915909

--- Comment #3 from Gregor Tätzner <[email protected]> ---
Created attachment 737355
  --> https://bugzilla.redhat.com/attachment.cgi?id=737355&action=edit
pre-review

looks good, just some items:

- license tag doesn't reflect the actual licenses: LGPL, GPL and FDL

- include license files in %doc

- also the changelog within dist directory

- imho examples should also be packaged (doc-subpkg?)

- consider to suffix all binaries with -qt5, not only qmlplugindump

- lots of hidden files in debuginfo (*.moc)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HuIaxEQiq1&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to