Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823
--- Comment #2 from Hans de Goede <[email protected]> --- (In reply to comment #1) > * Untested: The "Songlength Database" which is also touched by one of the > patches. I dunno what may have changed over the past years, whether it works > and whether it is still updated. I've tested this and it works :) The patch is only so that the Songlenghts.txt file can be optionally put under /usr/share/sidplayfp, so that it is available for all users, rather then each user needing to put it in ~/.local/share/sidplayfp separately. Also it has been send upstream and accepted there. > > make install DESTDIR=$RPM_BUILD_ROOT > > Just for the record, nowadays there's %make_install for that. I know, but whomever came up with that should have given it a better name, this is way too much like the bad %makeinstall, so I prefer the old way. > APPROVED Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t7A1spKQHF&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
