Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951817
Rex Dieter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #9 from Rex Dieter <[email protected]> --- per comment #8, let me clarify some things: $RPM_BUILD_ROOT is not deprecated. The only requirement is that one be consistent and not mix $RPM_BUILD_ROOT and %buildroot , per the referenced guideline text : "There is very little value in choosing one style over the other, since they will resolve to the same values in all scenarios. You should pick a style and use it consistently throughout your packaging." %make_install is ok. The aforementioned guideline explicitly says: "... Instead, Fedora packages should use: %make_install (Note the "_" !), make DESTDIR=%{buildroot} install or make DESTDIR=$RPM_BUILD_ROOT install. Those all do the same thing." Does that help? that said, I'll try to review this review :), and if all goes well, sponsor you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iCWEtbAee0&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
