Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=952632
Brendan Jones <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #11 from Brendan Jones <[email protected]> --- This is good to go once you address this: [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qtermwidget-devel ## See: http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_base_package; you are missing the %{?_isa} macro and the %{release} macro in your string. I won't repeat the fedora-review, but here's my synopsis - package meets naming guidelines, spec file is legible with consistent use of macros - license is permissable and is available to all packages and sub-packages - package(s) own all the files / directories it - rpmlint OK - built in mock OK - sane requires - package functions as expected This package is APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mRYmqMzbZe&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
