Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=955551
Matthias Runge <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #2 from Matthias Runge <[email protected]> --- Some nitpicks before starting a real review: - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib/python2.7/site- packages/flask_admin/translations/de/LC_MESSAGES/admin.mo See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles Please use %find_lang-macro, and please take care not to list files twice. That will probably imply, to list dirs separately. rpmlint lists 4 errors as well: Checking: python-flask-admin-1.0.5-1.fc20.noarch.rpm python-flask-admin.noarch: E: zero-length /usr/lib/python2.7/site-packages/flask_admin/contrib/pymongo/typefmt.py python-flask-admin.noarch: E: zero-length /usr/lib/python2.7/site-packages/flask_admin/tests/mock.py python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/select2/select2.css python-flask-admin.noarch: E: zero-length /usr/lib/python2.7/site-packages/flask_admin/static/select2/VERSION-IS-3.2 1 packages and 0 specfiles checked; 4 errors, 0 warnings. I usually silence those issues (zero-length) by including a comment into the file. Script without shebang has probably x-flags set, please remove them. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aJAS8CETQ1&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
