Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924333
--- Comment #11 from Dan Mashal <[email protected]> --- Naming: OK License: OK Packages installs and works: Yes. Package compiles on f18 and rawhide: Yes. f18: https://koji.fedoraproject.org/koji/taskinfo?taskID=5300293 f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5300099 MUST: =========== BuildRequires =========== Add: 1) gtk2-devel 2) gsettings-desktop-schemas-devel 3) rarian-compat (for disabling scrollkeeper) Drop: 1) dbus-glib-devel (provided by gtk2-devel) 2) drop specific versioning for libatasmart-devel (is this really needed?) =========== configure flags =========== MUST: 1) Please add --disable-schemas-compile to the configure flags 2) Is the nvidia flag required? Is there a way to get the aticonfig bit working? SHOULD: =========== rpmlint =========== 1) Please fix usage of spaces and tabs in spec file. Preferably use spaces over tabls. =========== Macros =========== 1) Under postun you can put all of the scriplets under one if/fi section. =========== Other =========== Is the sed/libtool command really needed? If so can you submit a pull request upstream so that it's not? If not, why? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yBmm1P4e9V&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
