Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=954182

--- Comment #3 from Volker Fröhlich <[email protected]> ---
Just remove the whole if clause, everything is working fine without it.

Don't ship the static library (.a). Either delete it or don't build it in the
first place.

# skipped RPATH due to build errors, also following upstream's spec example --
That comment is misleading. It's part of our guidelines not to allow rpaths,
refer to http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath.
Just drop it.

Please be more specific about the manfiles, the headers and also the name of
the library. Doing that, you'll notice, the manpages are installed in the wrong
place: /usr/share/man/man/man1/ctpp2-config.1.gz should be
/usr/share/man/man1/ctpp2-config.1.gz.

Don't ship INSTALL.

I'd suggest to not use the version macro in Patch0. You'd have to rename a
fitting patch on every update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pZg4qNfAnU&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to