Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957573

Gregor Tätzner <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]    |[email protected]

--- Comment #2 from Gregor Tätzner <[email protected]> ---
PRE-REVIEW

- please rename channel.xml to %{name}.xml and adjust the scriptlets
accordingly

"License:        Apache-v2"
- you just made that up, did you ;)? Use 'ASL 2.0'

- all folders located in %{pear_phpdir}/AWSSDKforPHP/ beginning with underscore
should be moved to %{pear_docdir} I don't know why just a couple of html files
are marked as doc in the package.xml.

- also this should be fixed:
php-aws-sdk.noarch: E: non-executable-script
/usr/share/pear/AWSSDKforPHP/_compatibility_test/sdk_compatibility_test_cli.php
0644L /usr/bin/env
php-aws-sdk.noarch: E: non-executable-script
/usr/share/pear/AWSSDKforPHP/_samples/cli-s3_progress_bar.php 0644L
/usr/bin/env

- watch your %doc macro

- "Source0:        Source0:
http://pear.amazonwebservices.com/get/sdk-%{version}.tgz"; leads to unexpected
results ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=EUWmEnZ1NM&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to