Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959672
Dan Horák <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #1 from Dan Horák <[email protected]> --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: 646ae93c4fc526b69fe2e0982e8cb801529cef9a libndp-20130504gitca3c399.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (LGPLv2+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel subpackge OK pkgconfig files in devel subpackage OK no libtool .la droppings. OK not a GUI app. - rpmlint complains a bit libndp-devel.x86_64: W: no-documentation => would be nice libndp.src: W: spelling-error %description -l en_US ndptool -> toadstool libndp.src: W: invalid-url Source0: libndp-20130504gitca3c399.tar.gz => can be ignored This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ULoXHQHgAA&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
