Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958881

--- Comment #4 from Mathieu Bridon <[email protected]> ---
Thanks for the comments Parag, here's a new submission.

Spec URL: http://bochecha.fedorapeople.org/packages/ibus-cangjie.spec
SRPM URL:
http://bochecha.fedorapeople.org/packages/ibus-cangjie-1.0-2.fc20.src.rpm

(In reply to comment #3)
> Suggestions:
> 1) Desktop files should be installed as per given in 
> https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-
> install_usage

Good catch, I added the desktop-file-validate thing for both desktop files.

But now I wonder, do you know of a way to have the Autotools stuff use
desktop-file-install when installing the desktop files? (I'm upstream, so if
that's easily doable, I'd rather get it done upstream)

> 2) Good to add some comment in spec for rpmlint error of
> hardcoded-library-path

Yeah, Adam asked for this as well above. I just added a quick note in the
%files section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=6V2qqM7WNY&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to