Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957815

Adrien Devresse <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]

--- Comment #1 from Adrien Devresse <[email protected]> ---
Hi, 

I take the responsability ofthis review.


I get a failure on EL5, you don't want to pacakge this software for EL5 ?

http://koji.fedoraproject.org/koji/taskinfo?taskID=5346381

First informal review :

- your patch for forcing the %doc macro is not needed, you can just use the
%{_docdir} macro.

- The %dir need to be used to define the ownership of
%{_libexecdir}/edg-mkgridmap to your package




Regards,
Adrien

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=UvfgGmkdh8&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to