Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585467 Parag AN(पराग) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #19 from Parag AN(पराग) <[email protected]> 2010-05-10 01:57:36 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2176309 + rpmlint output for SRPM and for RPM. mozilla-googlesharing.src: W: spelling-error Summary(en_US) Anonymizing -> Anonymity, Anatomizing, Anonymous mozilla-googlesharing.src: W: spelling-error %description -l en_US google -> Google, goggle, googly mozilla-googlesharing.noarch: W: spelling-error Summary(en_US) Anonymizing -> Anonymity, Anatomizing, Anonymous mozilla-googlesharing.noarch: W: spelling-error %description -l en_US google -> Google, goggle, googly ==> Ignore this. + source files match upstream url (sha1sum) af55ae4f48b2eb02eef0116e3269fa9898f02407 googlesharing-0.18-fx.xpi + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + mozilla firefox extension. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
