Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074
--- Comment #1 from Parag AN(पराग) <[email protected]> --- Review:- + Koji scratch build f20 -> http://koji.fedoraproject.org/koji/taskinfo?taskID=5383022 + rpmlint on rpms gave librime.src: W: invalid-url Source0: http://rimeime.googlecode.com/files/librime-0.9.8.tar.gz HTTP Error 404: Not Found librime.x86_64: W: no-manual-page-for-binary rime_dict_manager librime.x86_64: W: no-manual-page-for-binary rime_deployer librime-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 4 warnings. ==> Source is downloadable so no issues. + Source verified with upstream as http://rimeime.googlecode.com/files/librime-0.9.8.tar.gz : CHECKSUM(SHA256) this package : 94092a7d1990b949efe6b4bcf8e8351cee64a3abe7838770a775ecb02a1ef065 CHECKSUM(SHA256) upstream package : 94092a7d1990b949efe6b4bcf8e8351cee64a3abe7838770a775ecb02a1ef065 + License is valid and its text is include in LICENSE file Suggestions:- 1) Add -tools subpackage which will install rime_deployer and rime_dict_manager and let it Requires: %{name}%{?_isa} = %{version}-%{release} 2) package need to own directory %{_datadir}/cmake/rime 3) I don't think you need following for this package BuildRequires: xorg-x11-proto-devel, zlib-devel -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h3mp85u42J&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
