Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963693
Mikolaj Izdebski <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected]) --- Comment #1 from Mikolaj Izdebski <[email protected]> --- 1. Please create a separate script (generate-sources.sh) to generate clean tarball. It will make it easier for me to verify sources and should improve maintaiability in future. 2. Please describe the patch. Why is it needed? Is it upstreamable? Was it submited upstream? 3. According %pom_add_dep "commons-lang:commons-lang" Is this a bug (missing dependency)? Is upstream aware of it? Please clarify. 4. Readme files should not be installed with javadoc package. 5. Since you generated the tarball yourself it would make sense to name it better. Current name is 1.1-jenkins-20120928-clean.tar.gz, something standard like jenkins-commons-jelly-1.1.20120928-clean.tar.gz would probably be better. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8tXJcqCjIF&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
