Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=962451

Tom "spot" Callaway <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+

--- Comment #2 from Tom "spot" Callaway <[email protected]> ---
= Review =

Good:

- rpmlint checks return:

hibernate-jpa-2.1-api.src: W: invalid-url URL: http://www.hibernate.org/ HTTP
Error 403: Forbidden
hibernate-jpa-2.1-api.noarch: W: invalid-url URL: http://www.hibernate.org/
HTTP Error 403: Forbidden
hibernate-jpa-2.1-api-javadoc.noarch: W: invalid-url URL:
http://www.hibernate.org/ HTTP Error 403: Forbidden

All safe to ignore. Weird, but fine. :)

- package meets naming guidelines
- package meets packaging guidelines
- license (EPL and BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(675e7365e4c014369aeb62a284644c7fcb9a166e634c7466a05200f71fab1d99)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs ok
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Q0Ew97jhKt&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to