Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=962813

--- Comment #1 from Wolfgang Ulbrich <[email protected]> ---
Hi Hans,
you didn't assign a review from me, anyway i start working on yours.
I general your package looks good, but i've one questions.

Issues:
=======
- update-desktop-database is invoked when required
  Note: desktop file(s) in funguloids
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

faults positiv in every current review at the moment.

===== EXTRA items =====

Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Arch-ed rpms have a total of 20664320 bytes in /usr/share 20664320
     funguloids-1.06-1.fc20.x86_64.rpm

I'm not shure if this is fixable, because your package doesn't use /{libdir} ,
but it isn't noarch.
So i'm thinking, /usr/share/funguloids (20.3 MB) contains libaries for the
package.
Or did the package work if you move this directory to a noarch subpackage?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=WARA0Pq4DD&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to