https://bugzilla.redhat.com/show_bug.cgi?id=956669
--- Comment #4 from Antonio Trande <[email protected]> --- (In reply to Christopher Meng from comment #3) > > - .desktop file is already in the source archive; why do you add another one > > as Source1 ? > > Its bundled desktop file is invalid and doesn't match Fedora's standard, I > think rewriting one is better than patching. See 'desktop-file-edit' manpage. > > > - %{_datadir}/%{name} directory must be owned by the package > > You mean I should remove the asterisk? No. http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Forgetting_to_Include_a_Toplevel_Directory > > > - In erebus_source.txt file, the developer says: > > > > >The source code is released under the GPL v3 or later. > > >Please contact me if you have suggestions, bug fixes or whatever: mark dot > > >harman >at ntlworld dot com . > > > > I don't see any license file included, apart from docs/gpl.txt file that is > > not the GPLv3+ text file. > > Ok, I've mailed the author, hope he can fix that. > > Thanks! This is very important. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eoezVDnDM7&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
