https://bugzilla.redhat.com/show_bug.cgi?id=965007
Germán Racca <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Germán Racca <[email protected]> --- Hi Gillaume! Some comments: - This is a "noarch" package because you don't build anything (rpmlint complaints E: no-binary), so you must put "BuildArch: noarch" inside the spec file. - As this is a noarch plugin, you shouldn't use %{_libdir} as the install dir; instead you should use %{_datadir}. - You should create a directory called "trailsave" and install the plugin in it: %{_datadir}/trailsave/ - You should remove (unless you intend to maintain this package for EPEL5): - "BuildRoot" tag - "rm -rf %{buildroot}" from install section - the "%clean" section - "%defattr(-,root,root,-)" - There is no a separate license file in the source package, so you should ask upstream to include it. HTH somewhat, Germán. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=83GllQwE71&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
