https://bugzilla.redhat.com/show_bug.cgi?id=969992
Mikolaj Izdebski <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Mikolaj Izdebski <[email protected]> --- I'm not doing formal review (yet), just adding my comment. 1) Why don'y you use downloadable tarball? Github can generate tarballs for every tag, commit or branch, for example: http://github.com/undertow-io/jastow/archive/1.0.0.Alpha1.tar.gz Using downloadable tarball would ease maintenance, but also review (as I won't have to recreate the tarbal manually - automated tools can review sources if full tarball URL is given). 2) Explicit package requires are usually unneeded if you are using %mvn_build/%mvn_install. Did you check automatically generated package requires? They should be correct and complete. If not then you may have a bug in the POM file (missing dep) or there might be a bug in XMvn, in which case I would like to hear that. In either case you most likely can remove explicit Requires. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hYTsONkzC1&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
