https://bugzilla.redhat.com/show_bug.cgi?id=971236
Parag AN(पराग) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from Parag AN(पराग) <[email protected]> --- Review:- + Package builds in mock successfully + rpmlint on rpms gave sugar-deducto.noarch: W: spelling-error %description -l en_US children's -> children, childcare's, Nichiren's sugar-deducto.src: W: spelling-error %description -l en_US children's -> children, childcare's, Nichiren's 2 packages and 0 specfiles checked; 0 errors, 2 warnings. ==> this can be ignored + Source verified with upstream as (sha256sum) srpm tarball : db7bdea1c281aa9f6a850f58edb01388efe24568336bfa733472b17c385ed53a upstream tarball : db7bdea1c281aa9f6a850f58edb01388efe24568336bfa733472b17c385ed53a - License tag is not completely valid. + Rest looks as per packaging guidelines. Suggestions: 1) Don't use any backslash between %{buildroot} and %{_prefix}, so your %install should look like %{__python} ./setup.py install --prefix=%{buildroot}%{_prefix} 2) License tag should be GPLv3+ and MIT. Read https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses Also, Add a comment above license tag # sprites.py is in MIT and all other files in GPLv3+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QEWLpEo7dd&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
