https://bugzilla.redhat.com/show_bug.cgi?id=927421

--- Comment #5 from Dave Malcolm <[email protected]> ---
(In reply to Stephen Gallagher from comment #4)
> tl;dr: Package is approved. Minor (non-mandatory) changes can be made at
> import time.

Thanks!


> TODO:
>  * 'rm -rf %{buildroot}' can be removed from %install section, as no
> supported versions of Fedora or RHEL 6 require it.

Removed (bumping to 0.2-3)

>  * Please request upstream to add a license note to setup.py or else add a
> LICENSE file (it's uncleare if lgpl-2.1.txt represents the project license,
> so setup.py is ambiguous.

I've fixed this in upstream git as:
https://github.com/fedora-static-analysis/firehose/commit/ba49ecebc4e2ae1f3fddd9d991935d28f453689f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kjSlOIJbKK&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to