https://bugzilla.redhat.com/show_bug.cgi?id=972568
--- Comment #3 from Susi Lehtola <[email protected]> --- Initial notes: Source URL is incorrect Source0: http://prdownloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz see http://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Sourceforge.net ** BuildRequires: glibc-devel can be removed, it's one of the packages that's automatically installed anyway. ** The files don't belong in a package called uthash. Instead, they should go to uthash-devel as per the packaging guidelines. You can, of course, make uthash-devel provide uthash, so that installing uthash gives you uthash-devel. (There should be no main package.) ** I abhor rampant use of wildcards in %files, because they can lead to unwanted results, and often it's much clearer to just type out the few extra letters to make things clear to anyone reading the spec. So I really suggest changing %{_includedir}/* to %{_includedir}/ut*.h -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D346tqJLak&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
