https://bugzilla.redhat.com/show_bug.cgi?id=950171

Björn Esser <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?

--- Comment #3 from Björn Esser <[email protected]> ---
Hello Tom!

Some issues here:

 * License-tag misses some licenses:

   ---> s'!License:.*!& and MIT and X11!'

        (need to do a more intensive check, although)

 * build.log shows there might be missing BRs:

        Project MESSAGE: muParser was not found, please install muParser!
        Project MESSAGE: Using muParser libraries in .
        (shown several times during %build)

 * wrong perms on plugins:

        %{_libdir}/%{name}/plugins/*.so are 0775 should be 0755

 * mixed use of %{buildroot} and $RPM_BUILD_ROOT in spec

   ---> either use the former or the later

 * large noarched-data in arched pkg (~7.5 M)

   ---> you may want to move %{_datadir}/* into an unarched -common subpkg

Fix these issues, please and I'll take another run.

Cheers,
  Björn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=yoyAuHUDsp&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to