https://bugzilla.redhat.com/show_bug.cgi?id=973868
Alec Leamas <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] --- Comment #6 from Alec Leamas <[email protected]> --- Ouch... seems that I wasn't clear about the sed issues... :( The original sed patching of the desktop file was basically fine IMHO, besides that the was expressions needlessly complicated and the backup useless. My idea was to replace these with something like sed -i -e '/^Ĉategories/s/$/;/' -e /^MimeType/s/$/;/ lifeograph.desktop or so (nop patch here required, but doessn't, hjurt either, I guess) Mhy real concerns is the last expresseion sed -ibackup "81,86 d" wscript. This is just too vulnerable to even whitespace changes, and should be replaced with a patch IMHO. Sorry for the mess. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ymFQBIXm87&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
