https://bugzilla.redhat.com/show_bug.cgi?id=830869
Jaroslav Škarvada <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected] | |om) | --- Comment #5 from Jaroslav Škarvada <[email protected]> --- (In reply to Jason Tibbitts from comment #4) Spec URL: http://jskarvad.fedorapeople.org/hpl/hpl.spec SRPM URL: http://jskarvad.fedorapeople.org/hpl/hpl-2.1-2.fc18.src.rpm > I'm slightly confused; does this not support serial mode at all (i.e. can it > run without MPI)? I was not able to compile it without MPI, it seems to be mandatory. It would probably require more patching to make it optional. > Also, I'm not seeing the -common package which the > guidelines mandate. (It does look like those guidelines, or at least the > examples, need fixing now that we don't ship lam.) Added. > > I don't understand why you play sed games with _smp_mflags instead of just > calling make without passing _smp_mflags. What benefit is there from > calling make -j1 instead of just calling make? And even if there was > something, why not then actually call make -j1 instead of cooking up a macro > that does the same thing? The most safe way to work with probably any _smp_mflags value, e.g. it would handle any possible future extensions of these flags. Maybe a bit over-engineered, so I made it simple as proposed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XGApKjYJcs&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
