https://bugzilla.redhat.com/show_bug.cgi?id=975309
--- Comment #3 from Michael Schwendt <[email protected]> --- * Run "rpmlint -I" on all packages, the src.rpm *and* the built rpms. Apply fixes for obvious errors/warnings, ignore false positives, preferably comment on what rpmlint reports. > Name: libcutl > Group: Development/Libraries Rather "System Environment/Libraries" for base library packages, since those contain run-time libs as opposed to -devel packages. > License: Boost This needs a closer look, because the file LICENSE contains the MIT terms, and several source files mention MIT licensing, too. > # Other BuildRequires from auto-buildrequires > # NOTE: The Packaging Guidelines say that some of these can be exclude, but > just > # keep them here because it's easy and then they're include for completeness Hmmm, I'm certain lots of reviewers would insist on having you remove these. Saying "it's easy" isn't convincing, because it's even easier to not list anything expected to be available within the minimum build environment: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 > %package doc > Requires: %{name}%{?_isa} = %{version}-%{release} Separate documentation -doc packages typically don't require the base package. It should be possible to install documentation without having to install a program and all its dependencies. > %files > %{_libdir}/*.so The *.so symlink belongs into the -devel package, because typically it's only needed/used when building software: http://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages There are only few exceptions where external programs would dlopen a library via the non-versioned symlink (expect a few symbols only) and could not be patched to open the versioned lib instead. > %files devel > %{_includedir}/cutl/* Directory /usr/include/cutl is not included. http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership http://fedoraproject.org/wiki/Packaging:UnownedDirectories > %files doc > %{_datadir}/doc/libcutl/* Directory /usr/share/doc/libcutl is not included. Further, the size of the libcutl-doc package is 5496 bytes. Unless large API docs are missing, I wouldn't split off these few and tiny files into a separate -doc package, but include them within the base package. http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation $ rpmls -p libcutl-doc-1.7.1-1.fc19.x86_64.rpm -rw-r--r-- /usr/share/doc/libcutl/INSTALL -rw-r--r-- /usr/share/doc/libcutl/LICENSE -rw-r--r-- /usr/share/doc/libcutl/NEWS -rw-r--r-- /usr/share/doc/libcutl/README -rw-r--r-- /usr/share/doc/libcutl/version -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XfT4Nj1QW5&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
