https://bugzilla.redhat.com/show_bug.cgi?id=974714
--- Comment #9 from Marcelo Barbosa <[email protected]> --- Hello Srinivas, Your release is much better for this last version, but necessary see this it: Issues: ======= 1) Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in Only in /home/marcelo.barbosa/rpmbuild/SOURCES/reviews/974714-thermal_daemon/srpm-unpacked/thermal_daemon-v1.02.tar.gz-extract: thermal_daemon-1.02 Only in /home/marcelo.barbosa/rpmbuild/SOURCES/reviews/974714-thermal_daemon/upstream-unpacked/Source0: thermal_daemon-78b9dd1343bf7350740eb76e3bf87dc207078d9d Source checksums ---------------- https://github.com/01org/thermal_daemon/archive/78b9dd1343bf7350740eb76e3bf87dc207078d9d/thermal_daemon-v1.02.tar.gz : CHECKSUM(SHA256) this package : d870160e9d0518e2cc0e0fdc948e9feb28112638de70f696f393683a913893c2 CHECKSUM(SHA256) upstream package : 4c0beba121cb2769a6a423e2d861bbf1210d717c631d57d21e9001ad12205cd2 diff -r also reports differences Please see: http://fedoraproject.org/wiki/Packaging/SourceURL PS: You not use variable shortcommit in this line: Source0: https://github.com/01org/thermal_daemon/archive/%{commit}/%{name}-v%{version}.tar.gz 2) Please remove this line, is not necessary: Requires: libxml2 ERROR: thermal_daemon.x86_64: E: explicit-lib-dependency libxml2 3) About this question is mandatory, please see: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd Thank you and good working. Marcelo Barbosa Fedora Project Packager Fedora Project Ambassador [email protected] -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=djBJeDVDAE&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
