https://bugzilla.redhat.com/show_bug.cgi?id=808350
Christopher Meng <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #32 from Christopher Meng <[email protected]> --- Some problems IMO: 1. Upstream has release 5.35 so far. Please update again. 2. Why do you preserve %{_libdir}/*.*a files? 3. %{_usr}/share/ should be replaced by %{_datadir} 4. Better replace all ${RPM_BUILD_ROOT} by %{buildroot} 5. desktop-file-install must not add vendor. Besides, I suggest you should desktop-file-validate the file(but don't do that in spec, just outside the building sandbox) 6. In build section, make should with %{?_smp_mflags} 7. All subpackages Requires tag should have %{_isa} 8. Please put the %define debug_package %{nil} at the top of the spec. And please don't use %define, please use %global. 9. # These are the old names for this program. Obsoletes: plt-scheme Obsoletes: drscheme Where are they now? In Fedora I cannot find either of them. 10. Group tag can be removed as Fedora doesn't need this.(optional) 11. Remove the "." in the Summary tag. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jl336fLjN3&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
