https://bugzilla.redhat.com/show_bug.cgi?id=956304
--- Comment #11 from Dominik 'Rathann' Mierzejewski <[email protected]> --- Michał, you're supposed to provide a link to the latest specfile and src.rpm with each update, but I'll assume the URL for the specfile hasn't changed: https://grid-deployment.web.cern.ch/grid-deployment/dms/fts3/epel_release/fts.spec %changelog entries must be sorted in reverse-chronological order (i.e. newest entries at the top) and you should drop %{?dist} from the version-release tags there. Looking at the diff between current and previous spec, I still see some minor issues: %files python -%defattr(-,root,root,-) -%dir %attr(0755,fts3,root) %{python_sitearch}/fts +%dir %attr(0755,root,root) %{python_sitearch}/fts The %attr part in the %dir line is now redundant. Also, is there any reason not to have simply: %files python %{python_sitearch}/fts ? -python and -devel subpackages depend on the -libs subpackage, so including LICENSE and README as %doc in the two former packages is redundant. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TSRIrdiSEN&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
