https://bugzilla.redhat.com/show_bug.cgi?id=957693
--- Comment #11 from Adrien Devresse <[email protected]> --- Hi Mario, >The mixed-use-of-spaces-and-tabs is rather cosmetic but it is better to have >the same view in all text editors. I recommend to use whitespaces only, but it >is your choice. Use what you prefer, don't mix both. It's a false positive, this "space" is inside a comment. Anyway, I removed this upstream in order to silent the warning. > To uncouple the el5-specific stuff from newer versions, please make the > following parts of your spec file conditional for el5 only: * The BuildRoot definition * The initial cleaning of %{buildroot} in %install * The whole %clean section * The %defattr lines in the file lists I don't see the point to do this to be honest : - these EPEL specific part are not "against" fedora review guidelines ( https://fedoraproject.org/wiki/Packaging:ReviewGuidelines ), they are just mark as not "required". - They are in any case, ignored by the recent fedora. - Adding useless conditional macros make the spec file unreadable. - A lot of already reviewed fedora packages contains them without any problem : -> http://pkgs.fedoraproject.org/cgit/json-c.git/tree/json-c.spec?h=f19 -> http://pkgs.fedoraproject.org/cgit/leafpad.git/tree/leafpad.spec -> http://pkgs.fedoraproject.org/cgit/libnet.git/tree/libnet.spec -> http://pkgs.fedoraproject.org/cgit/librabbitmq.git/tree/librabbitmq.spec -> ... Adrien. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wo5dzcKrMF&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
