https://bugzilla.redhat.com/show_bug.cgi?id=976919
Michael Schwendt <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #1 from Michael Schwendt <[email protected]> --- There's not much to review here, so only very minor issues. The linked spec file is newer than what's included in the src.rpm. It removes the libtool archive. $ rpmlint * gnome-desktop-testing.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-desktop-testing-2013.1/COPYING gnome-desktop-testing.x86_64: W: no-manual-page-for-binary gnome-desktop-testing-runner gnome-desktop-testing-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gnome-desktop-testing-2013.1/src/gnome-desktop-testing-runner.c => https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address The exe-perm should be removed in upstream tarball release, too. > Summary: A test runner for installed tests That's *very* generic. In this case it wouldn't hurt to mention the relationship to the GNOME project, e.g. Summary: GNOME's test runner for installed tests Btw, typically, the leading articles (such as "A", "An", "The") don't look good in package tools or Anaconda. * Who will own the default directory /usr/share/installed-tests? The individual packages that store .test files somewhere below that dir? Will there be dependencies on this package? https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership All issues are no blockers and could be fixed in Fedora package git. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8tHRd4dPI6&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
