https://bugzilla.redhat.com/show_bug.cgi?id=896087
--- Comment #1 from Adrien Devresse <[email protected]> --- I take this review. Few comments : - From my knowledges, the directory ownership of %{_datadir}/%{name} need to be specify explicitely - Why not taking the source from the official github repo ? https://github.com/sstephenson/prototype/releases It include LICENSE file directly upstream and unit tests. - "prototype" is maybe just a bit generic for a name, Do you see any problem to name it something like prototypejs (which map the official website name) or prototype-javascript. Nothing is against this in the naming guidelines ( https://fedoraproject.org/wiki/Packaging:NamingGuidelines ), it's more a comment from my side. Adrien -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v8gWFusf9j&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
