https://bugzilla.redhat.com/show_bug.cgi?id=980960
Christopher Meng <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Christopher Meng <[email protected]> --- Aha... 1. Where is the URL tag, that means, where is the program's homepage? 2. Source0 should be a link which can directly be used to download the tarball or other sources. Only this style is for softwares which cannot provide a tarball. 3. "Requires: perl" is incorrect, please see: https://fedoraproject.org/wiki/Packaging:Perl#Versioned_MODULE_COMPAT_Requires 4. "Requires: /usr/bin/desktop-file-validate" is right but I think you can change it to desktop-file-utils 5. No need for "%clean section"/"%defattr(-,root,root,-)"/"rm -rf $RPM_BUILD_ROOT"(old habits should be trashed) 6. Do not mix variable and macros, you can change $RPM_BUILD_ROOT to %{buildroot} 7. If there are no docs, you don't need to write %doc with an empty line. 8. /usr/share in %files section can be replaced by %{_datadir} I'm not a sponsor, but please consider a fix for above issues. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=paepfR8wzS&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
