https://bugzilla.redhat.com/show_bug.cgi?id=980071

--- Comment #7 from Michael Schwendt <[email protected]> ---
There are a few more packaging mistakes:


* /usr/include/xpyb.h includes Python and xcb headers, so python-xpyb-devel is
missing dependencies


* the pkgconfig file links with libxcb, so python-xpyb-devel is missing
dependencies


* The package includes an unneeded .la file in the Python module dir:

| Libtool archives, foo.la files, should not be included.
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries


> %doc %{_docdir}/xpyb/*

Files in %_docdir are marked %doc automatically.
Plus https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=jYxYcqMDMa&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to