https://bugzilla.redhat.com/show_bug.cgi?id=977116
Volker Fröhlich <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Volker Fröhlich <[email protected]> --- Don't use the vendor tag: http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage Is there no icon? Also try to get the desktop file upstream, if you haven't done so yet. You can use the name macro for the patch names. I think you should rather use find than ls as a source to your loop. rm -rf %{buildroot} is no longer necessary. The locales aren't handled properly, see: http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files Are those libraries really intended to be public? If so, there should be header files and a devel-subpackage. /usr/bin/crashhandler is a potentially problematic name. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GgJBnNkj3Q&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
