https://bugzilla.redhat.com/show_bug.cgi?id=979674

Parag AN(पराग) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <[email protected]> ---
Review:

+ mock build is successful for f20

- rpmlint output on rpms gave
perl-File-Find-Object-Rule.noarch: E: wrong-script-interpreter
/usr/share/doc/perl-File-Find-Object-Rule-0.0303/scripts/findorule perl
2 packages and 0 specfiles checked; 1 errors, 0 warnings.


+ Source verified with upstream as (sha256sum)
srpm tarball     :
9957f61dbbfeafc57a6a7525d693a17f1135d5ab0eefcf7eb461b002ff355fd9
upstream tarball :
9957f61dbbfeafc57a6a7525d693a17f1135d5ab0eefcf7eb461b002ff355fd9

+ License "GPL+ or Artistic" is valid and included in source files.

+ rest follows packaging guidelines

+ make test is successful with output
All tests successful.
Files=6, Tests=53,  1 wallclock secs ( 0.04 usr  0.01 sys +  0.44 cusr  0.05
csys =  0.54 CPU)

+ Package perl-File-Find-Object-Rule-0.0303-1.fc20
Provides: perl(File::Find::Object::Rule) = 0.0303 perl-File-Find-Object-Rule =
0.0303-1.fc20

Requires: /usr/bin/perl perl(Carp) perl(Cwd) perl(File::Basename)
perl(File::Find::Object) perl(File::Find::Object::Rule) perl(File::Spec)
perl(File::Spec::Functions) perl(Number::Compare) perl(Text::Glob) perl(strict)
perl(vars) perl(warnings)

suggestions:
1) you may want to remove Requires: from spec to allow rpm to generate
automatically needed dependencies.

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Xrii3g5Zpu&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to