https://bugzilla.redhat.com/show_bug.cgi?id=957529

Christopher Meng <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #4 from Christopher Meng <[email protected]> ---
A suggestion:

Can you sort tags like this?

Name:           solaar
Version:        0.9.1
Release:        1%{?dist}
Group:          Applications/System
Summary:        Device manager for Logitech Unifying Receiver
License:        GPLv2
URL:            http://pwr.github.io/Solaar/
Source:         https://github.com/pwr/Solaar/archive/%{version}.tar.gz
BuildArch:      noarch

I think you should put URL tag with Source0(you wrote it as "Source", no
problem) tag.

An issue:

As you can see,

%{_datadir}/icons/hicolor/scalable/apps/solaar.svg

is presented in %files section.

So, please follow guideline:

http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

to add scripts for updating icon cache.

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=w5MfEwTagt&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to