https://bugzilla.redhat.com/show_bug.cgi?id=984700
Christopher Meng <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Christopher Meng <[email protected]> --- Initial review: 1. "BuildRequires: gcc-c++" is not needed, you can remove it. 2. You can simplify "%setup -q -n sddm-%{version}" to "%setup -q" 3. Systemd units files are handled incorrectly IMO. Ref: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd 4. Release tag should be 1%{?dist}, after the fix should be 2%{?dist} -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3LtxB4ANMr&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
