https://bugzilla.redhat.com/show_bug.cgi?id=983961
Mario Blättermann <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #3 from Mario Blättermann <[email protected]> --- Please provide a *downloadable* link: https://raw.github.com/F1ash/pyqt-mail-checker/2.0.1/pyqt-mail-checker.spec Your spec file link points to the website, not to the raw file. Well, I cannot speak for other reviewers, but I like to download both spec and srpm to a local folder and have a look at them. And if someone wants to view the file online, a browser should also be able to display plain text correctly. Github in particular (and probably some other VCS web viewers) doesn't have syntax highlighting, so there's no advantage of viewing it in the browser. Additionally to the missing icon cache update mentioned by Christopher, I'm missing the desktop file scriptlet: http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage make install DESTDIR=$RPM_BUILD_ROOT/usr Don't use /usr. We have the %{_prefix} macro therefore. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZY163532Sd&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
