https://bugzilla.redhat.com/show_bug.cgi?id=985051
Mario Blättermann <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #2 from Mario Blättermann <[email protected]> --- The C compiler and make are part of the minimum build environment: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 It is unneeded to mention them in BuildRequires. PREFIX=/usr has to be replaced with PREFIX=%{prefix}. Don't use such hardcoded paths. This also applies to the file list, we have macros for all system folders (%{_bindir}, %{_datadir}, %{_mandir} etc.). Don't use a certain file extension for manpages. Well, currently they are gzipped, but this could change in the future. Use an asterisk * instead: %{_mandir}/man1/vcprompt.1.* BTW, the man page is not directly to be added to %doc. But I'm missing README.txt here. rm -rf $RPM_BUILD_ROOT is an artifact from older Fedora releases. The current behavior defaults to that, so it can be safely dropped. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hZlT5OSH3J&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
