https://bugzilla.redhat.com/show_bug.cgi?id=975041
Dominik 'Rathann' Mierzejewski <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #5 from Dominik 'Rathann' Mierzejewski <[email protected]> --- Good review, Michał. Some minor nitpicks from myself below (can be fixed before first build in git): Summary: Common library for sblim-sfcb and sblim-sfcc This could be improved. Suggestion: Summary: Common functions for SBLIM Small Footprint CIM Broker and C library. You have 80 characters available, so use them well. :) Group: Development/Libraries This is redundant unless you intend to package for EL5. URL: http://www.sblim.org/ doesn't seem to be related to the project. Maybe http://sourceforge.net/projects/sblim/ would be better? By the way, I noticed that the URL for the existing sblim-sfcc package points to the same URL http://www.sblim.org/ , so you might want to fix that as well. Please investigate and report the unused dependency on libdl upstream, like Michał highlighted. Looks good otherwise, so: APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vOElPYAPk1&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
