https://bugzilla.redhat.com/show_bug.cgi?id=985916
Igor Gnatenko <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected], | |[email protected] Flags| |needinfo?(limburgher@gmail. | |com) --- Comment #1 from Igor Gnatenko <[email protected]> --- * Use %global instead of %define [0] * BuildRoot not needed since F10 [1] * Requires in -devel package need %{isa} at the end * %clean section isn't needed since F13 [2] * %{buildroot} instead of $RPM_BUILD_ROOT/ More about make install: make install LIBTOOL=/usr/bin/libtool DESTDIR=$RPM_BUILD_ROOT Why you're using "LIBTOOL=/usr/bin/libtool" ? and make install DESTDIR=... can replace with %make_install [0] https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define [1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag [2] https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZJmLLcvdqO&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
