Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=593559 Terje Røsten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Terje Røsten <[email protected]> 2010-05-19 04:52:23 EDT --- Some initial comments - use version macro in Source url: Source0: http://protobuf-c.googlecode.com/files/protobuf-c-%{version}.tar.gz Ref: https://fedoraproject.org/wiki/Packaging:SourceURL#Using_.25.7Bversion.7D - remove %check section if its empty or better: enable tests - don't ship static libs (.a) if not strictly needed. Remove .la files. Ref: https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries - devel package need deps on protobuf-devel (for ownership of %{_includedir}/google - don't include explicit req. on protobuf, rpmbuild picks it up itself. - include ChangeLog and TODO by using the %doc macro. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
