https://bugzilla.redhat.com/show_bug.cgi?id=957053



--- Comment #8 from Christopher Meng <[email protected]> ---
Pretty good.

Only 1 issue, this file is listed twice:
/usr/share/doc/groonga-normalizer-mysql

From your spec,

/home/rpmaker/Desktop/groonga-normalizer-mysql/rpms-unpacked/groonga-normalizer-mysql-1.0.5-3.fc20.i686.rpm/usr/share/doc/groonga-normalizer-mysql/AUTHORS
/home/rpmaker/Desktop/groonga-normalizer-mysql/rpms-unpacked/groonga-normalizer-mysql-1.0.5-3.fc20.i686.rpm/usr/share/doc/groonga-normalizer-mysql/COPYING
/home/rpmaker/Desktop/groonga-normalizer-mysql/rpms-unpacked/groonga-normalizer-mysql-1.0.5-3.fc20.i686.rpm/usr/share/doc/groonga-normalizer-mysql/lgpl-2.0.txt
/home/rpmaker/Desktop/groonga-normalizer-mysql/rpms-unpacked/groonga-normalizer-mysql-1.0.5-3.fc20.i686.rpm/usr/share/doc/groonga-normalizer-mysql/README
/home/rpmaker/Desktop/groonga-normalizer-mysql/rpms-unpacked/groonga-normalizer-mysql-1.0.5-3.fc20.i686.rpm/usr/share/doc/groonga-normalizer-mysql/README.md

Since you've used %doc magic to mark 3 of them as docs, why not marking the
other 2? ;)

Once you've marked files as %doc, no need to list the location again.

But if the makefile has installed docs to the
/usr/share/doc/groonga-normalizer-mysql, you can remove the directory by rm and
then use %doc magic to mark them again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=BKMw7GqFey&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to