https://bugzilla.redhat.com/show_bug.cgi?id=990569



--- Comment #2 from Miroslav Suchý <[email protected]> ---
text in %description should end with dot.

>sed -i '1d' Rakefile
I would prefer:
sed -i '1|#!/usr/bin/env|d' Rakefile
which is just safer in case content of Rakefile will change in future versions.

I prefer that README is in main package and not in -doc subpackage. As it give
you very brief guidance how to use that package and does not force user to
install -doc. But that is just my personal preference. Feel free to ignore me
in this point.

Just from quick glance. More deeply review will follow soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VTaNvtAkcO&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to