https://bugzilla.redhat.com/show_bug.cgi?id=988310
--- Comment #2 from Josef Stribny <[email protected]> --- Please fix: * Remove this commented line as it has no value nor purpose and it's confusing. #cp %{gem_name}.gemspec %{buildroot}/%{gem_spec} * Remove shebang from non-executable Rakefile #!/usr/bin/env rake * Remove BR on bundler. We try to avoid running test suites using bundler in Fedora. You should be able to run it without it by deleting its require from tests source code. BuildRequires: rubygem(bundler) * Please ask upstream to include and include license in a separate license file, especially, because this gem is a derivative work. Please consider: * Consider keeping original .gemspec in %doc for clarification since you are generating your own. %exclude %{gem_instdir}/%{gem_name}.gemspec Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jixBKLDW3c&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
