https://bugzilla.redhat.com/show_bug.cgi?id=910340
Joshua Small <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Joshua Small <[email protected]> --- Hi Sergey, This is an informal review as I cannot sponsor. I have run a koji build for you. You can see it here: http://koji.fedoraproject.org/koji/taskinfo?taskID=5714543 Spec file: * It would be cleaner if the commented lines were removed. * The Source0 line should be a URL where a tester can download the relevant source. * Buildroot is obsolete and should be removed rpmlint produces several relevant errors: E: no-changelogname-tag Your spec file must end with a changelog, see here: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs W: invalid-license GPL-3.0+ License must match the exact name here: https://fedoraproject.org/wiki/Licensing:Main I believe GPLv3+ is the correct tag. W: no-url-tag Please add a url tag for your application. A number of "macro in comment" tags are related to cleaning up commented out, unused lines. W: summary-not-capitalized Starting the summary with a capital will make it look better. You can see the results of the broken source tag: ACrpmbuild -ba ./boinctui.spec error: File /home/fedora/rpmbuild/SOURCES/boinctui-2.2.1.tar.gz: No such file or directory The build process also appears to ignore the %{optflags} macro. The spec file suggests there are no documents. At a minimum, a license file is required. There should at least be some level of instructions shipped with it also. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=99D4BcXs7Q&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
