https://bugzilla.redhat.com/show_bug.cgi?id=991221



--- Comment #5 from Michael Schwendt <[email protected]> ---
> The package is correct and follows all packaging guidelines, afaict.

Not yet.


> Requires:       numactl ncurses

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires


> + make -j5
> gcc -g -Wall -O2 -o cmd.o -c common/cmd.c
> gcc -g -Wall -O2 -o disp.o -c common/disp.c
> …

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags


> %{_mandir}/man8/%{name}.8.gz

Not in the guidelines, but you'll meet reviewers who recommend

  %{_mandir}/man8/%{name}.8*

so the compression applied by rpmbuild on-the-fly could be
customised/changed/disabled without breaking a (re)build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sHiktLiPxA&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to