https://bugzilla.redhat.com/show_bug.cgi?id=989143
--- Comment #6 from Ken Dreyer <[email protected]> --- In general, upstreams often set shebangs to "#!/usr/bin/env python" or "#!/usr/bin/env ruby". They do this to stay portable, but it is not really ideal for Fedora. If the executable is a script that the user is really supposed to run, then you should swap out the /usr/bin/env for the actual executable, eg. /usr/bin/ruby or /usr/bin/python. I'm not sure that this is codified in any of the formal guidelines. There was a push to get this standardized back in 2009: https://fedoraproject.org/wiki/Script_Interpreters_%28draft%29 but this effort did not reach completion, as there are still several packages that have Requires: /usr/bin/env. In this particular case, even if we swapped /usr/bin/env for /usr/bin/python, we still have the dependency problem where the -doc subpackage Requires python. Technically speaking, a user should not need Python in order to simply install a ruby -doc package. It's just added dependency bloat at that point. The reason that I preferred to use a Requires filter is that it felt less invasive to me than patching the source. I'm not intimately familiar with the reasons for why there was a Python file in that section of the tree to begin with. Since it's in "fixtures" I assume it's basically test data, but I didn't know what unintended side effect an actual patch to remove the shebang might bring. Ditto with chmod'ing. Since this is just in -doc, and the script doesn't really have to run directly, I figured the RPM Requires filter would be the simplest thing to keep us closer to upstream. https://fedoraproject.org/wiki/Staying_close_to_upstream_projects It's your package, so ultimately if you want to try to patch it out instead of using a Requires filter, that's fine - TMTOWTDI. Just as long as we aren't adding another RPM to the pile packages that happen to require /usr/bin/env. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lz179pxzWB&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
